馃帀 Added JDBC source connector bootstrap template #3819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 1, 2021 08:35
yaroslav-hrytsaienko
approved these changes
Jun 4, 2021
sherifnada
approved these changes
Jun 8, 2021
| @@ -0,0 +1 @@ | |||
| NEW_SOURCE_CHECKLIST.md | |||
There was a problem hiding this comment.
this .gitignore is no longer needed since we don't generate the NEW_SOURCE_CHECKLIST file
added 8 commits
June 8, 2021 15:19
sherifnada
changed the title
sherifnada
approved these changes
Jun 8, 2021
|
|
||
| # Airbyte's build system uses these labels to know what to name and tag the docker images produced by this Dockerfile. | ||
| LABEL io.airbyte.version=0.1.0 | ||
| LABEL io.airbyte.name=airbyte/source-scaffold-java-jdbc-generic |
There was a problem hiding this comment.
newline
Suggested change
| LABEL io.airbyte.name=airbyte/source-scaffold-java-jdbc-generic | |
| LABEL io.airbyte.name=airbyte/source-scaffold-java-jdbc-generic | |
| @@ -40,5 +40,6 @@ def addScaffoldTemplateTask(name, packageName,scaffoldParams=[]) { | |||
|
|
|||
| addScaffoldTemplateTask('Python Source', 'scaffold-source-python') | |||
| addScaffoldTemplateTask('Python HTTP API Source', 'scaffold-source-http') | |||
| addScaffoldTemplateTask('Java JDBC Generic Source', 'scaffold-java-jdbc-generic') | |||
There was a problem hiding this comment.
Suggested change
| addScaffoldTemplateTask('Java JDBC Generic Source', 'scaffold-java-jdbc-generic') | |
| addScaffoldTemplateTask('Java JDBC Source', 'scaffold-java-jdbc-generic') |
github-actions
bot
added
the
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ticket #3560 Create JDBC Java connector bootstrap template
How
Added a new template for code-generator
Pre-merge Checklist
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes