Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帀 Add Java destination generator #3820

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Jun 2, 2021

What

  • Add the code generator for java destination.
  • This generator also takes care of UUID generation.

Pre-merge Checklist

Recommended reading order

  1. plopfile.js
  2. connector-templates/destination-java/README.md.hbs

@tuliren tuliren requested a review from sherifnada June 2, 2021 17:29
@tuliren tuliren changed the title 馃帀 Add java destination generator 馃帀 Java destination generator Jun 2, 2021
@sherifnada sherifnada changed the title 馃帀 Java destination generator 馃帀 Add Java destination generator Jun 2, 2021
@michel-tricot
Copy link
Contributor

Can the template pass tests? I wonder if we should make the template an Echo to stdout with all the FIXMES

@michel-tricot
Copy link
Contributor

Very nice :D

@tuliren
Copy link
Contributor Author

tuliren commented Jun 2, 2021

Can the template pass tests? I wonder if we should make the template an Echo to stdout with all the FIXMES

What do you mean by "pass tests"? The newly generated connector code will pass the build task. Does that count?

Also not sure about the benefits of the echo approach. With that approach, no concrete file will be generated, right?

@michel-tricot
Copy link
Contributor

build counts!

I am just thinking about AirbyteMessageConsumer is there something we can do to make it a bit easier to create or more guided?

@tuliren
Copy link
Contributor Author

tuliren commented Jun 2, 2021

Got it. To clarify that the template files themselves are not part of any build task. It is the generated code from these templates that can pass the build.

The template is not much helpful in terms of facilitating the development of AirbyteMessageConsumer. That probably needs a CDK.

@tuliren tuliren merged commit 038b848 into master Jun 3, 2021
@tuliren tuliren deleted the liren/java-destination-generator branch June 3, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants