Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Salesforce: Use new delete method of HttpMocker for test_bulk_stream #38205

Merged
merged 3 commits into from
May 15, 2024

Conversation

aldogonzalez8
Copy link
Contributor

@aldogonzalez8 aldogonzalez8 commented May 15, 2024

What

Resolving Mock server tests: Support mocking delete

How

Use the new delete method of HttpMocker for test_bulk_stream

User Impact

e.g.
instead of

        HttpMocker()._mock_request_method(  
            "delete",
            HttpRequest(f"{_BASE_URL}/jobs/query/{_JOB_ID}"),
            [
                _RETRYABLE_RESPONSE,
                HttpResponse(""),
            ],
        )

Now we use:

        HttpMocker().delete(
            HttpRequest(f"{_BASE_URL}/jobs/query/{_JOB_ID}"),
            [
                _RETRYABLE_RESPONSE,
                HttpResponse(""),
            ],
        )

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 7:04pm

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however, I'd like to ask @maxi297 to say the same, before we merge.

Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small nit

docs/integrations/sources/salesforce.md Outdated Show resolved Hide resolved
@aldogonzalez8 aldogonzalez8 force-pushed the aldogonzalez8/use_http_mocker_delete_method branch from 62b12fe to 1ce7cae Compare May 15, 2024 18:56
@aldogonzalez8 aldogonzalez8 force-pushed the aldogonzalez8/use_http_mocker_delete_method branch from 1ce7cae to c5f29b6 Compare May 15, 2024 18:57
@aldogonzalez8 aldogonzalez8 merged commit 68324db into master May 15, 2024
33 checks passed
@aldogonzalez8 aldogonzalez8 deleted the aldogonzalez8/use_http_mocker_delete_method branch May 15, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants