Destinations CDK: Avoid issuing multiple create schema calls per stream. #38357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gisripa
changed the title
This was referenced May 20, 2024
Merged
edgao
force-pushed
the
gireesh/05-20-cdk-minor-refactor
branch
from
1a5dad4
to
6418310
Compare
This was referenced May 20, 2024
gisripa
force-pushed
the
gireesh/05-20-cdk-minor-refactor
branch
from
6418310
to
dd68b86
Compare
edgao
force-pushed
the
gireesh/05-20-cdk-minor-refactor
branch
from
dd68b86
to
6a28525
Compare
gisripa
force-pushed
the
gireesh/05-20-cdk-minor-refactor
branch
from
6a28525
to
d369bc7
Compare
edgao
approved these changes
May 20, 2024
There was a problem hiding this comment.
can you add a TODO delete this; superseded by DestinationHandler#createNamespaces to https://github.com/airbytehq/airbyte/blob/master/airbyte-cdk/java/airbyte-cdk/typing-deduping/src/main/kotlin/io/airbyte/integrations/base/destination/typing_deduping/SqlGenerator.kt#L37 ?
gisripa
force-pushed
the
gireesh/05-20-cdk-minor-refactor
branch
from
d369bc7
to
d7bca46
Compare
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Decoupling the create namespace call from per-stream operation interface.
This will be called in SyncOperation with distinct set of namespaces required within the Sync.
Review guide
User Impact
Can this PR be safely reverted and rolled back?