Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix secret #3851

Merged
merged 6 commits into from
Jun 4, 2021
Merged

Fix secret #3851

merged 6 commits into from
Jun 4, 2021

Conversation

ChristopheDuong
Copy link
Contributor

What

@ChristopheDuong ChristopheDuong marked this pull request as ready for review June 3, 2021 15:00
@auto-assign auto-assign bot requested review from davinchia and jrhizor June 3, 2021 15:00
@jrhizor jrhizor changed the title Fix secert Fix secret Jun 3, 2021
jrhizor
jrhizor reviewed Jun 3, 2021
View reviewed changes
Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a high level I like this but it looks like there's an NPE in acceptance tests. Whatever that case is should be added to the tests here when it's fixed.

@davinchia davinchia merged commit 900b522 into master Jun 4, 2021
@davinchia davinchia deleted the davinchia/fix-secert branch June 4, 2021 00:11
@ChristopheDuong ChristopheDuong mentioned this pull request Jun 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

@davinchia davinchia davinchia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristopheDuong @jrhizor @davinchia