CDK: make postgres temp_file_limit error a transient error #38667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
theyueli
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
theyueli
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
theyueli
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
theyueli
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
evantahler
reviewed
May 26, 2024
Comment on lines
152
to
158
| e.message!!.lowercase().contains("An I/O error occurred while sending to the backend") | ||
| (e.message!!.lowercase().contains("An I/O error occurred while sending to the backend") || | ||
| e.message!!.lowercase().contains("temporary file size exceeds temp_file_limit")) |
There was a problem hiding this comment.
It would be great to start building up a constant or array of these matchers somewhere
There was a problem hiding this comment.
There was a problem hiding this comment.
It would be great to start building up a constant or array of these matchers somewhere
Agreed.
evantahler
approved these changes
May 26, 2024
theyueli
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
theyueli
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
theyueli
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
theyueli
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
theyueli
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
theyueli
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
|
closing this to send PR from my branch of upstream repo instead of using my own fork. (to avoid the community-ci failure issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27090
A postgres throws a
temp_file_limiterror is translated to a system error for airbyte. I believe this is true for both postgres source and destination connectors.This change makes this error a transient error so that it won't trigger sentry.