Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Serpstat: Make Connector Compatible with Builder #38690

Merged
merged 5 commits into from
Jun 23, 2024
Merged

✨Source Serpstat: Make Connector Compatible with Builder #38690

merged 5 commits into from
Jun 23, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

  • Make the connector compatible with the builder

How

  • Import schema to manifest
  • Update docs,
  • Completely made compatible with the builder

User Impact

  • No impact, chore for maintainability.

Can this PR be safely reverted and rolled back?

  • YES 💚

@btkcodedev btkcodedev self-assigned this May 28, 2024
@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 5:07pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 28, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team May 28, 2024 04:02
natikgadzhi
natikgadzhi approved these changes Jun 22, 2024
View reviewed changes
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's see if CI gods are happy

@alafanechere alafanechere merged commit ebf4b43 into master Jun 23, 2024
32 checks passed
@alafanechere alafanechere deleted the btkcodedev/serpstatCompatible branch June 23, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi approved these changes

Assignees

@btkcodedev btkcodedev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation auto-merge connectors/source/serpstat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@btkcodedev @natikgadzhi @alafanechere @octavia-squidington-iii