Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataset location to BigQuery connector (issue #3277) #3889

Merged
merged 5 commits into from
Jun 7, 2021
Merged

Add dataset location to BigQuery connector (issue #3277) #3889

merged 5 commits into from
Jun 7, 2021

Conversation

ChristopheDuong
Copy link
Contributor

@ChristopheDuong ChristopheDuong commented Jun 4, 2021 •
edited
Loading

What

Closes #3277
Replicates #3887

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • Unit & integration tests added as appropriate (and are passing)
  • /test command documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README
    • CHANGELOG.md
    • Reference docs in the docs/integrations/ directory.
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

ChristopheDuong and others added 3 commits June 4, 2021 12:07
@ChristopheDuong
Update docs
85d0b41
@sabifranjo
Add dataset location to BigQuery connector (issue #3277) (#3887)
24cb27a 
* Add dataset location to Bigquery connector

* Bump destination-biqquery version 0.3.3 -> 0.3.4

Co-authored-by: Sabolc Franjo <sabolc.franjo@ev-box.com>
@ChristopheDuong
Fix build issue in tests
7a63ee2
@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Jun 4, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/905938817
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/905938817

@ChristopheDuong ChristopheDuong marked this pull request as ready for review June 4, 2021 10:45
@akoshterek
Copy link

I see the build is failing. Should we make some changes to fix it?

@ChristopheDuong
Copy link
Contributor Author

I see the build is failing. Should we make some changes to fix it?

No, we just need to publish the docker image to get that build error fixed., I'm just waiting for an approval from someone else (I can't approve it myself)

@ChristopheDuong ChristopheDuong merged commit 913c55d into master Jun 7, 2021
@ChristopheDuong ChristopheDuong deleted the contrib/bq-location branch June 7, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

@davinchia davinchia Awaiting requested review from davinchia

@masonwheeler masonwheeler Awaiting requested review from masonwheeler

Assignees
No one assigned
Labels
connectors/destination/bigquery connectors/destinations-warehouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to specify data location in BigQuery destination
5 participants
@ChristopheDuong @akoshterek @marcosmarxm @karinakuz @sabifranjo