Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帀 Added document for locating files in local destination on windows #3892

Merged
merged 7 commits into from
Jun 4, 2021

Conversation

MohamadHaziq
Copy link
Contributor

@MohamadHaziq MohamadHaziq commented Jun 4, 2021

What

Closes #2213

Added a document to help users find their data when using local destination as destination on Windows and WSL2

@auto-assign auto-assign bot requested review from davinchia and jrhizor June 4, 2021 14:40
@ChristopheDuong
Copy link
Contributor

Thanks for your contribution!!

I think this would solve the problem users encounters as described here #2213

Copy link
Contributor

@avaidyanatha avaidyanatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this!! Just some small grammar/clarity fixes.

docs/tutorials/locating-files-local-destination.md Outdated Show resolved Hide resolved
docs/tutorials/locating-files-local-destination.md Outdated Show resolved Hide resolved
docs/tutorials/locating-files-local-destination.md Outdated Show resolved Hide resolved
@marcosmarxm marcosmarxm changed the title Added document for locating files in local destination on windows 馃帀 Added document for locating files in local destination on windows Jun 4, 2021
MohamadHaziq and others added 4 commits June 5, 2021 00:29
Co-authored-by: Christophe Duong <christophe.duong@gmail.com>
Co-authored-by: Abhi Vaidyanatha <abhi@airbyte.io>
Co-authored-by: Abhi Vaidyanatha <abhi@airbyte.io>
Co-authored-by: Abhi Vaidyanatha <abhi@airbyte.io>
@marcosmarxm
Copy link
Member

Thanks @MohamadHaziq hope to see the Facebook Pages soon 馃殌

@marcosmarxm marcosmarxm merged commit 1ad283b into airbytehq:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out how to properly mount docker volumes on Windows
4 participants