Source MSSQL: Enabled SSL connections - #3893
Conversation
Sherif A. Nada (sherifnada)
left a comment
Sherif A. Nada (sherifnada)
left a comment
There was a problem hiding this comment.
implementation looks good but some blocking comments on tests. Feel free to ship once they are addressed
| import java.util.HashMap; | ||
| import java.util.List; | ||
|
|
||
| public class MssqlRdsSourceAcceptanceTest extends SourceAcceptanceTest { |
There was a problem hiding this comment.
instead of rewriting the entire class, why don't we extend the other acceptance test and make the db configuration overridable? This way we have complete DRY, just change which DB to connect to
|
|
||
| @Override | ||
| protected void setup(TestDestinationEnv testEnv) throws Exception { | ||
| db = new MSSQLServerContainer<>(DockerImageName.parse("airbyte/mssql_ssltest:dev").asCompatibleSubstituteFor("mcr.microsoft.com/mssql/server")) |
There was a problem hiding this comment.
why do we need a docker image if we are testing against RDS?
…ommon mssql acceptance test
|
/test connector=source-mssql
|
|
/publish connector=connectors/source-mssql
|
3 participants
What
Ticket: #3618 : Source MSSQL: Enable SSL connections
How
Exposed the configuration in the connector's spec.json which allows a user to choose one of the three configurations:
Constructed the correct JDBC URL based on the configurations input by the user.
Added Acceptance tests to run against the Amazon RDS instance (created in scope of #3619)
Pre-merge Checklist
Recommended reading order
test.javacomponent.ts