Source MSSQL: Enabled SSL connections #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
13 tasks
sherifnada
approved these changes
Jun 4, 2021
| import java.util.HashMap; | ||
| import java.util.List; | ||
|
|
||
| public class MssqlRdsSourceAcceptanceTest extends SourceAcceptanceTest { |
There was a problem hiding this comment.
instead of rewriting the entire class, why don't we extend the other acceptance test and make the db configuration overridable? This way we have complete DRY, just change which DB to connect to
|
|
||
| @Override | ||
| protected void setup(TestDestinationEnv testEnv) throws Exception { | ||
| db = new MSSQLServerContainer<>(DockerImageName.parse("airbyte/mssql_ssltest:dev").asCompatibleSubstituteFor("mcr.microsoft.com/mssql/server")) |
There was a problem hiding this comment.
why do we need a docker image if we are testing against RDS?
…ommon mssql acceptance test
|
/test connector=source-mssql
|
yaroslav-hrytsaienko
approved these changes
Jun 8, 2021
|
/publish connector=connectors/source-mssql
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ticket: #3618 : Source MSSQL: Enable SSL connections
How
Exposed the configuration in the connector's spec.json which allows a user to choose one of the three configurations:
Constructed the correct JDBC URL based on the configurations input by the user.
Added Acceptance tests to run against the Amazon RDS instance (created in scope of #3619)
Pre-merge Checklist
Recommended reading order
test.javacomponent.ts