-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating integrations destinations local files doccs #3910
updating integrations destinations local files doccs #3910
Conversation
* Now you can see all the files containing the replicated data using `ls` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After that you could execute cat filename
to get information from the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcosmarxm The change you suggested is good with me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the two files and pushed them.
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, thank you for the contribution @jacqueskpoty! I just have some small clarity changes and this should be good to go.
Co-authored-by: Abhi Vaidyanatha <abhi@airbyte.io>
Co-authored-by: Abhi Vaidyanatha <abhi@airbyte.io>
Co-authored-by: Abhi Vaidyanatha <abhi@airbyte.io>
Co-authored-by: Abhi Vaidyanatha <abhi@airbyte.io>
I considered the suggested changes and pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for making the changes @jacqueskpoty!
What
This change will help users to easily locate local JSON and local CSV files. The previous Docs at the following link :
https://docs.airbyte.io/integrations/destinations/local-json and
https://docs.airbyte.io/integrations/destinations/local-csv,
Explain how to customize the local directory that stores the replicated files and also states at the end that - " If Airbyte instance is running on the same computer that you are navigating with, you can open your browser to go to file:///tmp/airbyte_local and look at the replicated data locally "
However it does not state how to access the replicated files if you are running airbyte on a remote server or for some reason cant access the file by using the specified approach above (file:///tmp/airbyte_local)
So it's important to show the user how to get to those file though the shell command by accessing the not-so-obvious container which hosts them. In fact the container which hosts these files is the airbyte-scheduler which is not obvious at all. I'am an airbyte user and I thought those files were stored in the airbyte-server. Thus it's even important to let the user know how and where to get those local files at. Following is the change I made to the local JSON and local CSV docs:
I changed this
With this in both files
(If Airbyte instance is running on the same computer that you are navigating with, you can open your browser to go to file:///tmp/airbyte_local and look at the replicated data locally)
Access Replicated Data Files
docker exec -it airbyte-scheduler bash
cd ..
cd /tmp/airbyte_local
cd /{Directory_Specified}
ls