-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom debezium mssql converted for datetimeoffset type #39342
Remove custom debezium mssql converted for datetimeoffset type #39342
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love deleting code!
The tests confirm things still work.
We need to take at some point a good look at our custom converters. |
We convert
datetimeoffset
types in debezium incorrectly. assuming 7 decimal digits (precision).The conversion doesn't appear to be adding any value as defaults / nulls are handled correctly now by debezium.
Removing custom conversion of this type.
The string representation of a datetimeoffset during initial snapshot is identical to the one now coming from the debezium default converter:
2024-05-10 19:00:01.604805 +03:00
(note the 6 precision digits)