Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Postgres: Kotlin auto conversion src/main/java -> src/main/kotlin #39388

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Destination Postgres: Kotlin auto conversion src/main/java -> src/main/kotlin #39388

merged 1 commit into from
Jun 13, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jun 11, 2024 •
edited
Loading

What

Manually resurrected #39372 into Kotlin file since it already got merged.

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 9:44pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jun 11, 2024
@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Jun 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@gisripa gisripa changed the title destination-postgres-src-kotlin Destination Postgres: Kotlin auto conversion src/main/java -> src/main/kotlin Jun 11, 2024
@gisripa gisripa marked this pull request as ready for review June 11, 2024 01:24
@gisripa gisripa requested a review from a team as a code owner June 11, 2024 01:24
edgao
edgao approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (but spotbugs is failing...)

@gisripa gisripa force-pushed the gireesh/06-10-destination-postgres-src-kotlin branch 3 times, most recently from 0080158 to 49e7d11 Compare June 12, 2024 21:33
@gisripa gisripa force-pushed the gireesh/06-10-destination-postgres-src-kotlin branch from 49e7d11 to 3f276e6 Compare June 12, 2024 21:40
@gisripa gisripa merged commit 7fb208b into master Jun 13, 2024
32 checks passed
@gisripa gisripa deleted the gireesh/06-10-destination-postgres-src-kotlin branch June 13, 2024 17:36
xiaohansong pushed a commit that referenced this pull request Jun 14, 2024
@gisripa @xiaohansong
Destination Postgres: Kotlin auto conversion src/main/java -> src/mai…
9e708f1 
…n/kotlin (#39388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/postgres connectors/destination/postgres-strict-encrypt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gisripa @edgao @octavia-squidington-iii