Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Snowflake: Fix for adding airbyte_meta to raw in overwrite mode #39399

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Destination Snowflake: Fix for adding airbyte_meta to raw in overwrite mode #39399

merged 1 commit into from
Jun 11, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jun 11, 2024 •
edited
Loading

What

Fixes: https://github.com/airbytehq/oncall/issues/5555

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 3:27pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jun 11, 2024
@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Jun 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@gisripa gisripa changed the title destination-snowflake-oc-fix Destination Snowflake: Fix for adding airbyte_meta to raw in overwrite mode Jun 11, 2024
@gisripa gisripa marked this pull request as ready for review June 11, 2024 14:44
@gisripa gisripa requested a review from a team as a code owner June 11, 2024 14:44
@gisripa gisripa force-pushed the gireesh/06-11-destination-snowflake-oc-fix branch from e0fc6c0 to 4c55078 Compare June 11, 2024 14:46
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 11, 2024
edgao
edgao reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to also change the if (state.destinationState.isAirbyteMetaPresentInRaw) condition?

...te/integrations/destination/snowflake/typing_deduping/AbstractSnowflakeTypingDedupingTest.kt Show resolved Hide resolved
@gisripa gisripa force-pushed the gireesh/06-11-destination-snowflake-oc-fix branch from 4c55078 to 26b07ed Compare June 11, 2024 15:23
@gisripa gisripa enabled auto-merge (squash) June 11, 2024 15:25
@edgao edgao mentioned this pull request Jun 11, 2024
Merged
2 tasks
@gisripa gisripa merged commit 7995786 into master Jun 11, 2024
30 of 31 checks passed
@gisripa gisripa deleted the gireesh/06-11-destination-snowflake-oc-fix branch June 11, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gisripa @edgao @octavia-squidington-iii