🐛 Source Facebook Marketing: apply configured statuses to ads insight streams #39439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
maxi297
changed the title
octavia-squidington-iii
added
the
area/documentation
2 tasks
bazarnov
approved these changes
Jun 12, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Jun 14, 2024
… streams (#39439) Co-authored-by: williammcguinness <wmcguinness@findoctave.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Branching off of #37437 to address #36998
Big kudos to @wmcguinn-octave for identifying the issue and providing an initial PR!
How
By forcing all ads statuses as part of the AdsInsights job creation request. That way, we don't rely on the default for each edge (account, campaign, ad sets and ad) but always have the same effective statuses being returned.
Review guide
airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams/base_insight_streams.pyairbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_base_insight_streams.pyairbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/source.pyairbyte-integrations/connectors/source-facebook-marketing/unit_tests/integration/test_ads_insights_action_product_id.pyUser Impact
When the jobs are too big and ad status is deleted or archived, they should still be returned.
Can this PR be safely reverted and rolled back?
TODO