Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(registry): coerse null strings #39461

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Jun 13, 2024

What

The metrics data from metabase writes

This causes the platform to also ingest a null string

How

The raw Metrics is outside our immediate control.

So I simply updated the decoder to coerce "null" to null

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 3:54pm

Copy link
Contributor Author

bnchrch commented Jun 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bnchrch and the rest of your teammates on Graphite Graphite

@bnchrch bnchrch marked this pull request as ready for review June 13, 2024 15:58
@bnchrch bnchrch requested a review from a team as a code owner June 13, 2024 15:58
Copy link
Contributor Author

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the before and after locally and it works

Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally, but changes LGTM

@bnchrch bnchrch merged commit 5f1f7fe into master Jun 13, 2024
31 checks passed
Copy link
Contributor Author

bnchrch commented Jun 13, 2024

Merge activity

@bnchrch bnchrch deleted the 06-13-bug_registry_coerse_null_strings branch June 13, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants