Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destination-azure: fix AzureBlobStorageSpillTest #39465

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Jun 13, 2024

test was passing when run from IDE, but not when run with airbyte-ci. Issue was the hardcoding of the container's IP

@stephane-airbyte stephane-airbyte marked this pull request as ready for review June 13, 2024 16:40
@stephane-airbyte stephane-airbyte requested a review from a team as a code owner June 13, 2024 16:40
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 4:41pm

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte stephane-airbyte force-pushed the stephane/06-13-destination-azure_fix_azureblobstoragespilltest branch from 2874b23 to 51260a5 Compare June 13, 2024 16:41
@stephane-airbyte stephane-airbyte merged commit a74bd22 into master Jun 13, 2024
30 of 31 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/06-13-destination-azure_fix_azureblobstoragespilltest branch June 13, 2024 16:59
xiaohansong pushed a commit that referenced this pull request Jun 14, 2024
test was passing when run from IDE, but not when run with airbyte-ci. Issue was the hardcoding of the container's IP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants