Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST - Pnilan/test salesforce http client #39503

Closed
wants to merge 89 commits into from
Closed

TEST - Pnilan/test salesforce http client #39503

wants to merge 89 commits into from

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Jun 14, 2024

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

pnilan added 30 commits May 23, 2024 08:58
@pnilan
Update reference for ResponseAction
e09401c
@pnilan
Updates ErrorHandler, BackoffStrategy, and HttpRequester for ne…
3d4037a 
…w error handling flow
@pnilan
Update backoff strategies for new format
b49b0db
@pnilan
Updates factory method to provide default http response filter
2f02df9
@pnilan
Update composite handler to include valid max_retries
1c0848e
@pnilan
Update error handler, http_requester, and model_to_componet_factory, …
be1c8bf 
…and requester to align with python cdk error handler and backoff strategy. Removes `ResponseStatus`.
@pnilan
Updated tests for default_error_handler
d79e994
@pnilan
Add method for determining optimal error resolution when provided mul…
5c629d8 
…tiple
@pnilan
Update default error handler and composite error handler unit tests. …
2bd6c60 
…Removes response status unit tests.
@pnilan
Updates error handlers to maintain current behavior on response actio…
1523bae 
…n preference
@pnilan
Updates error handler tests to expected behavior
d8f4857
@pnilan
Updates reference to ResponseAction
be01417
@pnilan
Update http_response_filter tests to reflect updated default error ma…
a656980 
…pping
@pnilan
Update HttpResponseFilter to prioritize user inputted error messages
153eea5
@pnilan
Update declarative error handlers tests for updated backoff_time meth…
0a33f2f 
…od name
@pnilan
chore: format code
2dc8a89
@pnilan
Update http_requester and associated tests
3a93bbf
@pnilan
chore: lint
6c3315c
@pnilan
Merge branch 'master' into pnilan/airbyte-cdk-low-code-http-error-han…
f737791 
…dler
@pnilan
Update http requester to return response if no error handler, alignin…
bef56d2 
…g with previous behavior
@pnilan
mypy type checking
572933e
@pnilan
chore: format code
0cc790d
@pnilan
revert source-harvest files
42f9fd7
@pnilan
Updates poetry.lock
d231eff
@pnilan
Update wait_until_header tests for MagicMock spec
546c1d2
@pnilan
Update test for http response filter for correct behavior
9740aa6
@pnilan
Update variable type
1467382
@pnilan
Update conditional for type checking
06258b2
@pnilan
Update http response filter test
a3cdc2e
@pnilan
Update tests
f5fdf7d
pnilan added 19 commits June 11, 2024 12:40
@pnilan
Merge branch 'master' into pnilan/airbyte-cdk-low-code-http-client
ceace6e
@pnilan
Merge branch 'master' into pnilan/airbyte-cdk-low-code-http-error-han…
ba759f0 
…dler
@pnilan
update wait until header time backoff strategy
57031fe
@pnilan
Merge branch 'pnilan/airbyte-cdk-low-code-http-error-handler' into pn…
c0072c2 
…ilan/airbyte-cdk-low-code-http-client
@pnilan
Update for mypy
ee89ff2
@pnilan
Update tests for updated type
ed10145
@pnilan
Merge branch 'pnilan/airbyte-cdk-low-code-http-error-handler' into pn…
95db2e2 
…ilan/airbyte-cdk-low-code-http-client
@pnilan
chore: format code
b6892a9
@pnilan
Merge branch 'pnilan/airbyte-cdk-low-code-http-error-handler' into pn…
35e607a 
…ilan/airbyte-cdk-low-code-http-client
@pnilan
Update type checking
e62897b
@pnilan
Create functions for cleaner implementation
a055fe3
@pnilan
Remove test_retry_ignore as it's already tested
beae464
@pnilan
chore: type check
c84aeaa
@pnilan
Add tests for http_client, add retry_factor to ExponentialBackoffStra…
0b04c48 
…tegy
@pnilan
adds cached_property decorator to max_time, factor, max_retries
a0f4e4b
@pnilan
Update http_client per comments
4c3c056
@pnilan
chore: format code
d73cebc
@pnilan
Conform error handler and backoff strategy interfaces to python cdk
7db87c3
@pnilan
updates to test http client PR
b557565
@vercel Vercel
Copy link

vercel bot commented Jun 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 16, 2024 11:25pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/salesforce labels Jun 14, 2024
@pnilan pnilan closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/source/salesforce
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pnilan @octavia-squidington-iii