Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(airbyte-cdk): add DatetimeIntervalCursor #39603

Merged
merged 7 commits into from
Jun 19, 2024

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Jun 19, 2024

What

Create a datetime cursor that can be sliced without intersections

How

Added is_compare_strictly, a toggle field to switch between strict and non-strict comparison.

User Impact

No

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@lazebnyi lazebnyi requested a review from a team as a code owner June 19, 2024 20:32
Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 10:57pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jun 19, 2024
@lazebnyi lazebnyi requested a review from girarda June 19, 2024 20:33
@lazebnyi lazebnyi requested a review from girarda June 19, 2024 20:59
@lazebnyi lazebnyi force-pushed the lazebnyi/add-datetime-interval-cursor branch from 42508b0 to 3d12c48 Compare June 19, 2024 21:33
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits. thanks for the quick turnaround @lazebnyi !

@lazebnyi lazebnyi merged commit a284676 into master Jun 19, 2024
28 checks passed
@lazebnyi lazebnyi deleted the lazebnyi/add-datetime-interval-cursor branch June 19, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants