fix network boundary error / format #4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to just merge this for now to fix the master build. Let me know if you want any changes for the error handling. |
github-actions
bot
added
area/documentation
jamakase
reviewed
Jun 10, 2021
| @@ -36,6 +36,7 @@ abstract class AirbyteRequestService { | |||
| resultJsonResponse = await response.json(); | |||
| } catch (e) { | |||
| // non json result | |||
| throw new CommonRequestError(response, "non-json response"); | |||
There was a problem hiding this comment.
Actually, we do not need to throw error here. This section was ignored intentionally to follow the same flow for all errors.
There was a problem hiding this comment.
If we don't throw here then we get an NPE in throw new CommonRequestError(response, resultJsonResponse.message); because resultJsonResponse isn't defined.
| @@ -27,7 +27,10 @@ class ApiErrorBoundary extends React.Component<unknown, BoundaryState> { | |||
| return { errorId: ErrorId.VersionMismatch, message: error.message }; | |||
| } | |||
|
|
|||
| if (error.message === "Failed to fetch") { | |||
| const isNetworkBoundaryMessage = error.message === "Failed to fetch"; | |||
| const is502 = error.status === 502; | |||
There was a problem hiding this comment.
This ErrorBoundary was assumed to keep level of errors processing as low as possible. I think we should probably add SeverUnavailableError class and move processing to AirbyteRequestService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jamakase fyi