Fail without enqueueing iff the airbyte message type is unrecognized #40254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
edgao
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
couple nitpicks, LGTM once those are resolved
FYI how to publish the cdk:
- https://github.com/airbytehq/airbyte/blob/master/airbyte-cdk/java/airbyte-cdk/README.md#bumping-the-cdk-version
- and also add an entry to the changelog at the bottom
...-cdk/core/src/test/kotlin/io/airbyte/cdk/integrations/base/AirbyteTraceMessageUtilityTest.kt
Outdated
Show resolved
Hide resolved
...ore/src/test/kotlin/io/airbyte/cdk/integrations/destination/async/AsyncStreamConsumerTest.kt
Show resolved
Hide resolved
airbyte-cdk/java/airbyte-cdk/dependencies/src/main/kotlin/io/airbyte/commons/json/Jsons.kt
Show resolved
Hide resolved
...ore/src/test/kotlin/io/airbyte/cdk/integrations/destination/async/AsyncStreamConsumerTest.kt
Show resolved
Hide resolved
| if (match != null) { | ||
| val unrecognized = match.groups[1]?.value | ||
| logger.warn { "Unrecognized message type: $unrecognized" } | ||
| return null |
There was a problem hiding this comment.
I'd rather throw a typed exception than return null here. This way, we also avoid all the !! everywhere we know this to be valid
johnny-schmidt
force-pushed
the
issue-8064/throw-recoverable-on-unrecognized-enums
branch
from
37f5987
to
f3bb580
Compare
|
@stephane-airbyte I think your comments have been addressed. |
stephane-airbyte
approved these changes
Jun 26, 2024
johnny-schmidt
deleted the
issue-8064/throw-recoverable-on-unrecognized-enums
branch
xiaohansong
pushed a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Addresses this Zenhub issue: when the airbyte message type is unrecognized, log an error instead of throwing the exception.
How
NOTE: This means that we will never call enqueue with the byte size passed into accept. However, @stephane-airbyte noticed that we do nothing with this when the type is unrecognized anyway (which may be a mistake if something's relying on that matching the calls to accept).
cc @edgao
User Impact
User should notice very little. In the rare event we add a new message type, it will not be a breaking change.
Can this PR be safely reverted and rolled back?
Yes, as long as we are not in the middle of the process of releasing a new message type. :)