Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Native Gitlab connector #4027

Merged
merged 22 commits into from
Jul 6, 2021
Merged

🎉 Native Gitlab connector #4027

merged 22 commits into from
Jul 6, 2021

Conversation

yevhenii-ldv
Copy link
Contributor

@yevhenii-ldv yevhenii-ldv commented Jun 10, 2021 •
edited

What

closes #3694.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README
    • CHANGELOG.md
    • Reference docs in the docs/integrations/ directory.
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jun 10, 2021 •
edited by github-actions bot

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/925399586
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/925399586

@yevhenii-ldv yevhenii-ldv changed the title (WIP) Create Native Gitlab connector 🎉 Native Gitlab connector Jun 14, 2021
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jun 14, 2021 •
edited by github-actions bot

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/936168112
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/936168112

@github-actions github-actions bot added the area/connectors Connector related issues label Jun 15, 2021
@Zirochkaa
Copy link
Contributor

Zirochkaa commented Jun 17, 2021 •
edited by github-actions bot

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/945457907
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/945457907

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jun 17, 2021 •
edited by github-actions bot

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/946618902
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/946618902

@vitaliizazmic vitaliizazmic requested a review from keu June 18, 2021 06:35
keu
keu requested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed to pick up ticket and make fixes myself

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jun 29, 2021 •
edited by github-actions bot

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/982965142
❌ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/982965142

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jun 29, 2021 •
edited by github-actions bot

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/982993230
❌ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/982993230

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jun 29, 2021 •
edited by github-actions bot

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/983073016
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/983073016

@yevhenii-ldv yevhenii-ldv requested a review from keu June 29, 2021 14:45
keu
keu approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but have two comments that need to be addressed... please ping if we need further discussion about it

sherifnada
sherifnada approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once open comments are addressed

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 2, 2021
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jul 2, 2021 •
edited by github-actions bot

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/993710669
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/993710669

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jul 6, 2021 •
edited by github-actions bot

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1003726100
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1003726100

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jul 6, 2021 •
edited by github-actions bot

/publish connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1004327455
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1004327455

@yevhenii-ldv yevhenii-ldv merged commit 94f1d21 into master Jul 6, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/new-source-airbyte-native-gitlab branch July 6, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@keu keu keu approved these changes

@Zirochkaa Zirochkaa Zirochkaa approved these changes

@vitaliizazmic vitaliizazmic vitaliizazmic approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Source: Airbyte-native Gitlab connector
5 participants
@yevhenii-ldv @Zirochkaa @keu @sherifnada @vitaliizazmic