-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(source-adjust): fix datetime format #41055
bug(source-adjust): fix datetime format #41055
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for the fix! @marcosmarxm I've kicked off the CI, let's see how that goes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also bump the version in pyproject.toml
, metadata.yaml
and changelog in docs? CI is going to complain about it.
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Thx @natikgadzhi for reviewing the pull request. I have bumped the versions.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a conflict with another PR that updated dependencies automatically. Bumped the version to 0.1.9, let's see how the CI feels about this.
Hello your feedback matters a lot to us. Can you spare just 2 minutes to complete a survey? We’re dedicated to making the contributor experience even better, and your input is key to achieving excellence. Thank you for helping us improve! |
Co-authored-by: Natik Gadzhi <natik@respawn.io>
What
Fixes datetime format in source-adjust manifest. Closes Issue: #41054
How
DatetimeBasedCursor creates a dateime in format "%Y-%m-%dT%H:%M:%SZ" which is expected by the adjust API
User Impact
No user impact expected
Can this PR be safely reverted and rolled back?