Source Amazon Seller Partner: Error for max wait time reached when create report status is CANCELLED or FATAL #4108
Conversation
2. Fix: Error for max wait time reached when create report status is CANCELLED or FATAL
harshithmullapudi
force-pushed
the
harshith-amazon-2
branch
from
3cc025f
to
a71de82
Compare
marcosmarxm
added
CDK
| @@ -66,21 +66,6 @@ def test_check_connection(mocker): | |||
|
|
|||
| assert ORDERS_RESPONSE == base_client.check_connection() | |||
|
|
|||
|
|
|||
| def test_get_cursor_state(): | |||
There was a problem hiding this comment.
why did you get rid of this?
There was a problem hiding this comment.
I removed this function also not needed anymore
| @@ -8,6 +8,10 @@ | |||
| "title": "Orders", | |||
| "description": "All orders that were updated after a specified date", | |||
| "properties": { | |||
| "seller_id": { | |||
There was a problem hiding this comment.
is this a new field? or was this field previously ignored?
| "type": "string", | ||
| "description": "The role’s arn (needs permission to “Assume Role” STS)" | ||
| }, | ||
| "seller_id": { |
There was a problem hiding this comment.
spoke offline with Harshith: This is used to generate the refresh_token and is how amazon actually know what data to return in the query even though this id is not passed into the query at all. Because of this, it's actually useful to inject this data into the generated record so users know where the data came from.
There was a problem hiding this comment.
Nice! The status changes makes sense to me. Couple of questions so I understand what the seller id is used for - if it's not part of the api, why pass it in?
- Can you run
./gradlew formatto make sure formatting is correct? - Can you add a local test with mocks to make sure the status logic is correct.
- Can you add a changelog to the directory similar to https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-shopify/CHANGELOG.md? Not all our sources have this, but we are trying to get there.
- Can you update the amazon seller partner documentation with the additional parameter being added?
github-actions
bot
added
the
area/documentation
harshithmullapudi
force-pushed
the
harshith-amazon-2
branch
from
b04e926
to
4473a50
Compare
marcosmarxm
changed the title
|
Can we merge this or is there something pending from my side @tuliren ? |
|
There are two more versions that need to be bumped. But I can do that for you. Will merge the PR first. |
What
Error for max wait time reached when create report status is CANCELLED or FATAL
How
When create report status returns either of the status we pass to next month