Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /approve-regression-tests workflow #41637

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Jul 11, 2024

This should fix an error in the approve-regression-tests-command.yml workflow:

Invalid workflow file: .github/workflows/approve-regression-tests-command.yml#L4The workflow is not valid. .github/workflows/approve-regression-tests-command.yml (Line: 4, Col: 3): Unexpected value 'status'
--


[Invalid workflow file: .github/workflows/approve-regression-tests-command.yml#L4](https://github.com/airbytehq/airbyte/actions/runs/9895409102/workflow)
The workflow is not valid. .github/workflows/approve-regression-tests-command.yml (Line: 4, Col: 3): Unexpected value 'status'

Not sure exactly how this line got in there but it appears to have snuck in from copy/paste after testing.

@clnoll clnoll requested a review from alafanechere July 11, 2024 16:56
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Jul 11, 2024 4:56pm

Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might still need the status: write permission at the job level to post to the Github API. In any case feel free to use the /approve-and-merge command for this kind of fixes 👍

@clnoll clnoll merged commit cd1682a into master Jul 11, 2024
29 checks passed
@clnoll clnoll deleted the catherine/fix-approve-regression-tests-workflow branch July 11, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants