[Source-postgres] : Throw exception if there are any streams acively undergoing vacuum #41651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
postamar
reviewed
Jul 12, 2024
| if (!streamsUnderVacuum.isEmpty()) { | ||
| throw new ConfigErrorException( | ||
| "Postgres database is undergoing a full vacuum - cannot proceed with the sync. Please sync again when the vacuum is finished."); | ||
| } |
There was a problem hiding this comment.
Do we really want this to be a ConfigErrorException? Don't we want to retry syncing later on?
There was a problem hiding this comment.
Good point, will change to TransientErrorException
octavia-squidington-iii
added
the
area/documentation
postamar
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case never occurs as it involves holding an exclusive lock on the table. If it doess happen, the query will not succeed. We can simplify code by throwing an exception if this ever occurs.