Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ source-clazar: removed redundant columns from streams, added documentation for analytics #41657

Merged
merged 17 commits into from
Jul 18, 2024
Merged

✨ source-clazar: removed redundant columns from streams, added documentation for analytics #41657

merged 17 commits into from
Jul 18, 2024

Conversation

prashant-mittal9
Copy link
Contributor

@prashant-mittal9 prashant-mittal9 commented Jul 12, 2024 •
edited
Loading

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Jul 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 6:18pm

@prashant-mittal9 prashant-mittal9 changed the title ✨ source-clazar: fixed streams schema declarations ✨ source-clazar: updated streams schema declarations Jul 12, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jul 12, 2024
@prashant-mittal9 prashant-mittal9 marked this pull request as draft July 12, 2024 01:52
@prashant-mittal9 prashant-mittal9 marked this pull request as draft July 12, 2024 01:52
marcosmarxm
marcosmarxm reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prashant-mittal9 let us know when this is ready to review.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 14, 2024
@prashant-mittal9 prashant-mittal9 marked this pull request as draft July 17, 2024 12:29
@prashant-mittal9 prashant-mittal9 changed the title ✨ source-clazar: flattened streams json objects ✨ source-clazar: removed redundant columns from streams, added documentation for analytics Jul 17, 2024
@prashant-mittal9 prashant-mittal9 marked this pull request as ready for review July 17, 2024 12:51
marcosmarxm
marcosmarxm requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is missing the update the connector version in the pyproject and metadata file.

@marcosmarxm
Copy link
Member

@natikgadzhi we need to /approve this. Can you double check it? The file is a valid connector in Builder.

marcosmarxm
marcosmarxm approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosmarxm marcosmarxm merged commit 7e38768 into airbytehq:master Jul 18, 2024
34 checks passed
@marcosmarxm
Copy link
Member

Hello your feedback matters a lot to us. Can you spare just 2 minutes to complete a survey? We’re dedicated to making the contributor experience even better, and your input is key to achieving excellence. Thank you for helping us improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/clazar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prashant-mittal9 @marcosmarxm @octavia-squidington-iii