fix gke file copy errors #4214
Merged
fix gke file copy errors #4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
cgardens
approved these changes
Jun 18, 2021
|
Hi. Is this bug fixed in newest version? We encountered this problem, too. |
|
@wwulfric this bug has been fixed since this was merged in mid-June |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, gke file upload isn't working reliably on the fabric8 client (see fabric8io/kubernetes-client#2217). We tried to work around it in #4195. Even when the message says it succeeded its behavior varied. I've seen cases where it successfully copied the contents, cases where it partially copied, and cases where it copied no contents at all (and this was after fixing the other bugfix in this pr, which is to make sure the success file flag is copied last).
I haven't been able to reproduce this a single time after switching to the official client for this operation. The only reason I'm not tearing out all of the fabric8 client usage and only using the official client is because the api is so much more ergonomic in fabric8. Both libraries are about equally popular and have comparable development activity. This is the first serious issue we've seen with fabric8's client. If we see any other serious issues we should revisit our client decision.
This bug would have been detected with acceptance tests that run on GKE: #4212