Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes v2 docs #4234

Merged
merged 6 commits into from Jun 21, 2021
Merged

kubernetes v2 docs #4234

merged 6 commits into from Jun 21, 2021

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Jun 21, 2021 •
edited

No description provided.

@jrhizor jrhizor requested a review from davinchia June 21, 2021 03:07
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jun 21, 2021
@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 21, 2021

A lot of the "operator guide" stuff actually isn't easy to port over to Kubernetes. I think we'll mostly omit those for now since they are mostly useful for internal use.

We should add upgrade docs for Kube, too.

davinchia
davinchia reviewed Jun 21, 2021
View reviewed changes
docs/contributing-to-airbyte/developing-on-kubernetes.md

```bash
# BE CAREFUL, THIS COMMAND DELETES ALL RESOURCES, EVEN NON-AIRBYTE ONES!
kubectl delete "$(kubectl api-resources --namespaced=true --verbs=delete -o name | tr "\n" "," | sed -e 's/,$//')" --all
Copy link
Contributor

@davinchia davinchia Jun 21, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be easier to use kubectl delete -k <path to your overlay>?

@jrhizor jrhizor marked this pull request as ready for review June 21, 2021 16:34
@jrhizor jrhizor changed the title kubernetes v2 logs kubernetes v2 docs Jun 21, 2021
@jrhizor
Copy link
Contributor Author

jrhizor commented Jun 21, 2021

@avaidyanatha should we add https://docs.google.com/presentation/d/1vSXy7GgqYjspz4yacHDuqInoxWM4aInuJ_3XhUBTn0U/edit#slide=id.p somewhere for external users or just keep it near our internal architecture docs?

@avaidyanatha
Copy link
Contributor

@avaidyanatha should we add https://docs.google.com/presentation/d/1vSXy7GgqYjspz4yacHDuqInoxWM4aInuJ_3XhUBTn0U/edit#slide=id.p somewhere for external users or just keep it near our internal architecture docs?

We should definitely add this in a public place, this could be important info for debugging.

avaidyanatha
avaidyanatha approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@avaidyanatha avaidyanatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks @jrhizor!

@avaidyanatha avaidyanatha merged commit 51bb5cc into master Jun 21, 2021
@avaidyanatha avaidyanatha deleted the jrhizor/kube-v2-docs branch June 21, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia left review comments

@avaidyanatha avaidyanatha avaidyanatha approved these changes

@cgardens cgardens Awaiting requested review from cgardens

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrhizor @avaidyanatha @davinchia