Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Snowflake: Added new comprehensive data type tests #4318

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

irynakruk
Copy link
Contributor

@irynakruk irynakruk commented Jun 24, 2021

What

Provided all the data types supported natively by the Snowflake DB

How

Added comprehensive data type tests. A Follow up ticket for found bugs had been created #4316

Recommended reading order

  1. x.java

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Reference docs in the docs/integrations/ directory.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

@irynakruk irynakruk linked an issue Jun 24, 2021 that may be closed by this pull request
@github-actions github-actions bot added the area/connectors Connector related issues label Jun 24, 2021
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@irynakruk irynakruk marked this pull request as ready for review July 5, 2021 14:21
@irynakruk irynakruk merged commit 6532774 into master Jul 6, 2021
@irynakruk irynakruk deleted the irynakruk/4033-snowflake-comprehensive-test branch July 6, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Snowflake: create comprehensive data type tests
3 participants