Build Core Docker Images and Run Tests should only do composeBuild

[cgardens]

What

The step mentioned in the title is running unit tests. This is superfluous as these steps are meant to run acceptance tests. Running the unit tests is always duplicative with the build step. replace build => composeBuild and remove the test directive.

Why

Our python infra is still flakey so PRs like this one get all fouled up due to unrelated problems.

[davinchia]

Unrelated, I merged in a change that should resolve the checkPython error we see. That branch was running into it since my change wasn't present.

Agree explicitly using composeBuild is good. One thing I wasn't sure is the diff between CORE_ONLY and composeBuild.

[davinchia]

Actually it looks like composeBuild and CORE_ONLY have similar intent?

composeBuild only builds these submodules while CORE_ONLY excludes connectors from formatting and building connector projects. We should get rid of one. Wdyt?

[davinchia]

thoughts @jrhizor ?

[jrhizor]

# jrhizor in ~/code/airbyte on git:master ✖︎ [21:43:52]
→ CORE_ONLY=true ./gradlew build --dry-run | wc -l
     738

# jrhizor in ~/code/airbyte on git:master ✖︎ [21:43:57]
→ ./gradlew composeBuild  --dry-run | wc -l
     121

CORE_ONLY=true ./gradlew build runs tests + works with normalization/other code and ./gradlew composeBuild doesn't. They do have different functionality.

To be honest, in my own flow, I pretty much only run CORE_ONLY=true ./gradlew format but ./gradlew composeBuild for everything else.