run docker acceptance tests once

[cgardens]

What

• The current github action configurations runs the docker acceptance tests twice. They are run in the build job and also in the run acceptance test job. This appears to be purely duplicative. I don't really care where we run them. Happy to keep the extra job and just remove it from the build, but doing it twice doesn't make sense to me.

[davinchia]

This is true for master, but isn't true for PR builds: https://github.com/airbytehq/airbyte/blob/master/.github/workflows/gradle.yml#L124

I think we should remove && github.ref == 'refs/heads/master' as well so the docker acceptance tests always build. This way, we can be sure the acceptance test at least pass for docker before we publish dev images.

[cgardens]

okay! I'll remove that condition here. agreed we always want these to run at this point.

though one thing you mentioned doesn't quite make sense to me. the dev images also only get pushed on master, so even as it is now (before removing the condition) we already always run the acceptance tests before publishing the dev image)

[jrhizor]

I think this makes sense.

Before the EC2 runners, I think the main build was almost 2x the length of the acceptance test, and the acceptance test was 90% of what you needed to be confident making core changes, so it was great for iteration in a branch.

Now that there's only a 6min difference it doesn't matter as much.