Tweak .env in kube/overlays to connect to external db #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopheDuong
changed the title
jrhizor
approved these changes
Jun 30, 2021
kube/overlays/dev/.env
Outdated
| DATA_DOCKER_MOUNT=airbyte_data | ||
| DB_DOCKER_MOUNT=airbyte_db | ||
|
|
||
| # Internal Temporal.io deployment |
There was a problem hiding this comment.
Suggested change
| # Internal Temporal.io deployment | |
| # Temporal.io worker configuration |
kube/overlays/stable/.env
Outdated
| DATA_DOCKER_MOUNT=airbyte_data | ||
| DB_DOCKER_MOUNT=airbyte_db | ||
|
|
||
| # Internal Temporal.io deployment |
There was a problem hiding this comment.
Suggested change
| # Internal Temporal.io deployment | |
| # Temporal.io worker configuration |
kube/resources/scheduler.yaml
Outdated
| @@ -51,7 +61,7 @@ spec: | |||
| - name: WAIT_BEFORE_HOSTS | |||
| value: "5" | |||
| - name: WAIT_HOSTS | |||
| value: airbyte-db-svc:5432 | |||
| value: $(DATABASE_HOST):$(DATABASE_PORT) | |||
There was a problem hiding this comment.
I don't think this works since it never is resolved to the correct value?
→ kubectl describe pod airbyte-scheduler-7764b66c8c-5n6bm | grep WAIT_HOSTS\:
WAIT_HOSTS: $(DATABASE_HOST):$(DATABASE_PORT)
Eventually we should remove wait entirely since we're waiting within code with finer control. For now we can just hard code the host and port again...
ChristopheDuong
force-pushed
the
chris/kube_env
branch
from
a1fe858
to
9f85001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Mirror changes from #4211 to kube
.envtooHow
Describe the solution