Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Facebook Marketing: update cursor_field for Ads Insights Streams #4437

Merged
merged 8 commits into from
Jul 1, 2021
Merged

Source Facebook Marketing: update cursor_field for Ads Insights Streams #4437

merged 8 commits into from
Jul 1, 2021

Conversation

yevhenii-ldv
Copy link
Contributor

@yevhenii-ldv yevhenii-ldv commented Jun 30, 2021 •
edited by keu

What

copy #4376 .

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Jun 30, 2021
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jun 30, 2021 •
edited by github-actions bot

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/986591443
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/986591443

@yevhenii-ldv yevhenii-ldv requested a review from keu June 30, 2021 14:37
keu
keu approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update changelog

@keu keu requested review from sherifnada and removed request for sherifnada June 30, 2021 21:11
@keu
Copy link
Contributor

keu commented Jun 30, 2021

@yevhenii-ldv I think we can merge this

@harshithmullapudi
Copy link
Contributor

harshithmullapudi commented Jul 1, 2021 •
edited

Thanks a lot 😃 @keu and @yevhenii-ldv

@github-actions github-actions bot added the area/platform issues related to the platform label Jul 1, 2021
ykurochkin added 2 commits July 1, 2021 17:08
Merge branch 'master' of github.com:airbytehq/airbyte into harshith-fb
3dd56e2 
� Conflicts:
�	airbyte-server/src/main/resources/seed/source_definitions.yaml
fix old file
f1f63c7
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jul 1, 2021 •
edited by github-actions bot

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/990368322
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/990368322

@github-actions github-actions bot removed the area/platform issues related to the platform label Jul 1, 2021
keu
keu approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just move changelog to docs as all other

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 1, 2021
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Jul 1, 2021 •
edited by github-actions bot

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/990450939
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/990450939

@yevhenii-ldv yevhenii-ldv merged commit 83ac92b into master Jul 1, 2021
@yevhenii-ldv yevhenii-ldv deleted the harshith-fb branch July 1, 2021 14:50
@yevhenii-ldv yevhenii-ldv mentioned this pull request Jul 1, 2021
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keu keu keu approved these changes

@Zirochkaa Zirochkaa Zirochkaa approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yevhenii-ldv @keu @harshithmullapudi @Zirochkaa @karinakuz