Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New source: Square #4439

Merged
merged 39 commits into from
Jul 7, 2021
Merged

Conversation

TymoshokDmytro
Copy link
Contributor

@TymoshokDmytro TymoshokDmytro commented Jun 30, 2021

What

New source Square request

How

Implement streams for next API endpoints:

Recommended reading order

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

@github-actions github-actions bot added the area/connectors Connector related issues label Jun 30, 2021
@TymoshokDmytro TymoshokDmytro linked an issue Jun 30, 2021 that may be closed by this pull request
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jun 30, 2021
if not json_payload:
json_payload = {}

args = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    locations_stream = Locations{
        "authenticator": self.authenticator,
        "is_sandbox": self.is_sandbox,
        "api_version": self.api_version,
        "start_date": self.start_date,
        "include_deleted_objects": self.include_deleted_objects,
    }
    locations_records = locations_stream.read_records(sync_mode=SyncMode.full_refresh)
    location_ids = [location["id"] for location in locations_records]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Refactor like you mentioned

@TymoshokDmytro
Copy link
Contributor Author

TymoshokDmytro commented Jul 5, 2021

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/999778339
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/999778339

@TymoshokDmytro
Copy link
Contributor Author

TymoshokDmytro commented Jul 5, 2021

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1000852433
✅ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1000852433
🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1000852433
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1000852433

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall really solid implementation, some small questions and we should be ready to go

@TymoshokDmytro
Copy link
Contributor Author

TymoshokDmytro commented Jul 7, 2021

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1007857383
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1007857383
🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1007857383
✅ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1007857383

@TymoshokDmytro
Copy link
Contributor Author

TymoshokDmytro commented Jul 7, 2021

/publish connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1008277801
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1008277801
🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1008277801
✅ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1008277801

@TymoshokDmytro TymoshokDmytro merged commit b8b205a into master Jul 7, 2021
@TymoshokDmytro TymoshokDmytro deleted the dtymoshok/#3013-New-source-Square branch July 7, 2021 17:20
@TymoshokDmytro
Copy link
Contributor Author

TymoshokDmytro commented Jul 8, 2021

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1012213875
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1012213875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New source: Square
4 participants