-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New source: Square #4439
🎉 New source: Square #4439
Conversation
airbyte-integrations/connectors/source-square/source_square/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-square/source_square/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-square/source_square/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-square/source_square/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-square/source_square/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-square/source_square/source.py
Outdated
Show resolved
Hide resolved
if not json_payload: | ||
json_payload = {} | ||
|
||
args = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
locations_stream = Locations{
"authenticator": self.authenticator,
"is_sandbox": self.is_sandbox,
"api_version": self.api_version,
"start_date": self.start_date,
"include_deleted_objects": self.include_deleted_objects,
}
locations_records = locations_stream.read_records(sync_mode=SyncMode.full_refresh)
location_ids = [location["id"] for location in locations_records]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Refactor like you mentioned
/test connector=connectors/source-square
|
/test connector=connectors/source-square
|
airbyte-integrations/connectors/source-square/source_square/utils.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-square/source_square/source.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall really solid implementation, some small questions and we should be ready to go
airbyte-integrations/connectors/source-square/source_square/utils.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-square/source_square/utils.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-square/source_square/source.py
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-square
|
/publish connector=connectors/source-square
|
/test connector=connectors/source-square
|
What
New source Square request
How
Implement streams for next API endpoints:
Recommended reading order
Pre-merge Checklist
Expand the checklist which is relevant for this PR.
Connector checklist
airbyte_secret
in the connector's spec./gradlew :airbyte-integrations:connectors:<name>:integrationTest
./test connector=connectors/<name>
command as documented here is passing.README.md
docs/SUMMARY.md
if it's a new connectordocs/integrations/<source or destination>/<name>
.docs/integrations/...
. See changelog exampledocs/integrations/README.md
contains a reference to the new connector/publish
command described here