Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 bugfix Source Okta: Fix endless loop while syncing data from logs stream #4464

Merged
merged 6 commits into from
Jul 2, 2021
Merged

🐛 bugfix Source Okta: Fix endless loop while syncing data from logs stream #4464

merged 6 commits into from
Jul 2, 2021

Conversation

sherifnada
Copy link
Contributor

@sherifnada sherifnada commented Jul 1, 2021 •
edited

What

Publishing PR #4456

Pre-merge Checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

@sabifranjo
🐛 bugfix Source Okta: Fix endless loop while syncing data from logs s…
a44d273 
…tream (#4456)

Co-authored-by: Sabolc Franjo <sabolc.franjo@ev-box.com>
@github-actions github-actions bot added the area/connectors Connector related issues label Jul 1, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 1, 2021
@sherifnada
Copy link
Contributor Author

sherifnada commented Jul 1, 2021 •
edited by github-actions bot

/publish connector=connectors/source-okta

🕑 connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/990997403
❌ connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/990997403

@github-actions github-actions bot added the CDK Connector Development Kit label Jul 1, 2021
@sherifnada
Copy link
Contributor Author

/publish connector=connectors/source-okta

@sherifnada
Copy link
Contributor Author

sherifnada commented Jul 1, 2021 •
edited by github-actions bot

/publish connector=connectors/source-okta

🕑 connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/991280154
✅ connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/991280154

@github-actions github-actions bot removed the CDK Connector Development Kit label Jul 2, 2021
@sherifnada sherifnada merged commit 9708e4c into master Jul 2, 2021
@sherifnada sherifnada deleted the sherif/merge-pr-4456 branch July 2, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sherifnada @sabifranjo