Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zendesk airbyte entrypoint #4469

Merged
merged 15 commits into from
Jul 3, 2021
Merged

Zendesk airbyte entrypoint #4469

merged 15 commits into from
Jul 3, 2021

Conversation

marcosmarxm
Copy link
Member

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@marcosmarxm marcosmarxm requested a review from jrhizor July 1, 2021 18:03
@github-actions github-actions bot added the area/connectors Connector related issues label Jul 1, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 1, 2021 •
edited by github-actions bot

/test connector=connectors/source-zendesk-support-singer

🕑 connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/991061017
❌ connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/991061017

jrhizor
jrhizor suggested changes Jul 1, 2021
View reviewed changes
airbyte-integrations/connectors/source-zendesk-support-singer/Dockerfile Outdated
@@ -5,11 +5,12 @@ RUN apt-get update && apt-get install -y bash && rm -rf /var/lib/apt/lists/*
ENV CODE_PATH="source_zendesk_support_singer"
ENV AIRBYTE_IMPL_MODULE="source_zendesk_support_singer"
ENV AIRBYTE_IMPL_PATH="SourceZendeskSupportSinger"
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/source.py"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/source.py"
ENV AIRBYTE_ENTRYPOINT "/airbyte/base.sh"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker inspect airbyte/source-zendesk-support-singer:0.2.2 shows /airbyte/base.sh as the existing entrypoint.

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 1, 2021 •
edited by github-actions bot

/test connector=connectors/source-zendesk-support-singer

🕑 connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/991152554
❌ connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/991152554

@jrhizor
Copy link
Contributor

jrhizor commented Jul 1, 2021 •
edited

looks like this probably has to be pushed with skipping tests with /publish connector=connectors/source-zendesk-support-singer run-tests=false since it's been failing constantly https://status-api.airbyte.io/tests/summary/source-zendesk-support-singer/

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 1, 2021 •
edited by github-actions bot

/publish connector=connectors/source-zendesk-support-singer run-tests=false

🕑 connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/991848309
❌ connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/991848309

@marcosmarxm
Copy link
Member Author

Failed to apply plugin 'airbyte-python'.
A problem occurred configuring project ':airbyte-integrations:connectors:source-zoom-singer'.
> Could not open cp_proj generic class cache for build file '/home/runner/work/airbyte/airbyte/airbyte-integrations/connectors/source-zoom-singer/build.gradle' (/home/runner/.gradle/caches/6.7.1/scripts/4ffd4lk4g399iqzx3xoc30xgr).
> java.lang.StackOverflowError (no error message)

I dont understand the CI error :( @sherifnada any idea why CI is failing to publish zendesk support and is calling zoom?

@sherifnada
Copy link
Contributor

not sure about zoom but previous failed runs of this workflow have been because the schema of the configured catalog used in testing is out of date, requires destination_sync_mode

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 2, 2021 •
edited by github-actions bot

/test connector=connectors/source-zendesk-support-singer

🕑 connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/994187014
❌ connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/994187014

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 2, 2021 •
edited by github-actions bot

/test connector=connectors/source-zendesk-support-singer

🕑 connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/994379602
✅ connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/994379602

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 2, 2021 •
edited by github-actions bot

/publish connector=connectors/source-zendesk-support-singer

🕑 connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/994496808
❌ connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/994496808

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 2, 2021 •
edited by github-actions bot

/publish connector=connectors/source-zendesk-support-singer

🕑 connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/994511165
❌ connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/994511165

@marcosmarxm marcosmarxm mentioned this pull request Jul 2, 2021
Closed
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 2, 2021 •
edited by github-actions bot

/publish connector=connectors/source-zendesk-support-singer

🕑 connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/995065549
❌ connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/995065549

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 2, 2021 •
edited by github-actions bot

/publish connector=connectors/source-zendesk-support-singer

🕑 connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/995100822
❌ connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/995100822

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 2, 2021 •
edited by github-actions bot

/publish connector=connectors/source-zendesk-support-singer

🕑 connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/995140520
✅ connectors/source-zendesk-support-singer https://github.com/airbytehq/airbyte/actions/runs/995140520

@davinchia davinchia merged commit 68f78d5 into master Jul 3, 2021
@davinchia davinchia deleted the marcosmarxm/zendesk-entrypoint branch July 3, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcosmarxm @jrhizor @sherifnada @davinchia