Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish PR (#4121) #4495

Merged
merged 11 commits into from
Jul 2, 2021
Merged

Publish PR (#4121) #4495

merged 11 commits into from
Jul 2, 2021

Conversation

sherifnada
Copy link
Contributor

@sherifnada sherifnada commented Jul 2, 2021 •
edited

merging contribution #4121

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in output spec
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Documentation updated
    • README
    • CHANGELOG.md
    • Reference docs in the docs/integrations/ directory.
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 2, 2021
@sherifnada
Copy link
Contributor Author

sherifnada commented Jul 2, 2021 •
edited by github-actions bot

/test connector=source-shopify

🕑 source-shopify https://github.com/airbytehq/airbyte/actions/runs/992836430
✅ source-shopify https://github.com/airbytehq/airbyte/actions/runs/992836430

@sherifnada
Copy link
Contributor Author

sherifnada commented Jul 2, 2021 •
edited by github-actions bot

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994380570
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994380570

@sherifnada
Copy link
Contributor Author

sherifnada commented Jul 2, 2021 •
edited by github-actions bot

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994397430
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994397430
🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994397430
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994397430
🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994397430
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994397430

@sherifnada
Copy link
Contributor Author

sherifnada commented Jul 2, 2021 •
edited by github-actions bot

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994484591
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994484591

@sherifnada
Copy link
Contributor Author

sherifnada commented Jul 2, 2021 •
edited by github-actions bot

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994514286
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994514286

@sherifnada
Copy link
Contributor Author

sherifnada commented Jul 2, 2021 •
edited by github-actions bot

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994580475
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994580475

@sherifnada
Copy link
Contributor Author

sherifnada commented Jul 2, 2021 •
edited by github-actions bot

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994715680
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/994715680

@sherifnada sherifnada changed the title merge PR 4121 Publish PR 4121 Jul 2, 2021
@sherifnada sherifnada changed the title Publish PR 4121 Publish #4121 Jul 2, 2021
@sherifnada sherifnada changed the title Publish #4121 Publish PR (#4121) Jul 2, 2021
@sherifnada sherifnada merged commit 9079cbd into master Jul 2, 2021
@sherifnada sherifnada deleted the sherif/merge-4121 branch July 2, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sherifnada @rparrapy