Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Publish airbyte-native twilio connector #4529

Merged
merged 28 commits into from
Jul 5, 2021
Merged

🎉 Publish airbyte-native twilio connector #4529

merged 28 commits into from
Jul 5, 2021

Conversation

htrueman
Copy link
Contributor

@htrueman htrueman commented Jul 3, 2021 •
edited

What

Added source definitions to publish the connector.
Follow up the #4070 PR.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@htrueman
Add Twilio CDK source
5274f54
@htrueman
Merge remote-tracking branch 'origin/master' into htrueman/airbyte-na…
8e327d7 
…tive-twilio-connector
@htrueman
Implement all streams full refresh support.
be91bc6
@htrueman
Complete all streams and configs.
815b793
@htrueman
Apply code format
da1fdce
@htrueman
Fix streams data response.
d205848 
Update streams which should not be incremental.
Fix configs.
@htrueman
Merge remote-tracking branch 'origin/master' into htrueman/airbyte-na…
893a837 
…tive-twilio-connector
@htrueman
Fix incremental streams.
b209013 
Fix configs.
@htrueman
Fix acceptance tests config.
459fcc2
@htrueman
Fix stream schemas.
5a68dbc
@htrueman
Fix messages stream schema.
7736ddc
@htrueman
Catalogs fixed
58a8bf2
@htrueman
Update setup requirements.
6c9356f
@htrueman
Add standard CI creds
986f3a7
@htrueman
Update build.gradle and sample config files to remove unused references
ca7ca60
@htrueman
Updated sample config files json format
0f1b2b2
@htrueman
Update streams.py
cda720f
@htrueman
Update incremental streams cursor_field formatting
284a194
@htrueman
Update streams and test config
dc7a30e
@htrueman
Add no_empty_streams_no_usage_records_catalog.json
39277c1
@htrueman
Update streams code style.
51a8b96 
Add twilio.md docs.
Other PR style fixes.
@htrueman
Update twilio.md docs.
8c41223
@htrueman
Odd docstring removed.
f7aef89
@htrueman
Merge remote-tracking branch 'origin/master' into htrueman/airbyte-na…
60f6bfd 
…tive-twilio-connector
@htrueman
Uncomment tests.
70ff45a
@htrueman
Add Docker AIRBYTE_ENTRYPOINT
d9616c6
@htrueman
Add source definitions
ff03861
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 3, 2021
@htrueman
Copy link
Contributor Author

htrueman commented Jul 3, 2021 •
edited by github-actions bot

/publish connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/996805232
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/996805232
🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/996805232
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/996805232
🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/996805232
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/996805232
🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/996805232
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/996805232

sherifnada
sherifnada reviewed Jul 4, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also update builds.md?

airbyte-config/init/src/main/resources/seed/source_definitions.yaml Outdated Show resolved Hide resolved
@htrueman htrueman changed the title Htrueman/airbyte native twilio connector 🎉 Publish airbyte-native twilio connector Jul 5, 2021
@htrueman
Update twilio source definitions
b8c0a9a 
Remove twilio singer source
@github-actions github-actions bot added the area/platform issues related to the platform label Jul 5, 2021
@htrueman
Copy link
Contributor Author

htrueman commented Jul 5, 2021 •
edited by github-actions bot

/publish connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/1000264516
✅ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/1000264516

@htrueman
Copy link
Contributor Author

htrueman commented Jul 5, 2021 •
edited by github-actions bot

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/1000366104
✅ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/1000366104

@htrueman htrueman merged commit d382d1b into master Jul 5, 2021
@htrueman htrueman deleted the htrueman/airbyte-native-twilio-connector branch July 5, 2021 09:36
This was linked to issues Jul 5, 2021
🎉 New Source: Pipedrive #3321
Closed
new source: airbyte-native twilio connector #3697
Closed
@htrueman htrueman removed a link to an issue Jul 5, 2021
🎉 New Source: Pipedrive #3321
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada left review comments

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new source: airbyte-native twilio connector
2 participants
@htrueman @sherifnada