馃帀 API: Add an endpoint to list workspaces #4530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
|
Thanks @mmolimar I'm going to review later today! |
sherifnada
reviewed
Jul 4, 2021
There was a problem hiding this comment.
@mmolimar looks great! thanks for adding it. Just a small request for unit tests and we should be ready to go 馃帀
| @@ -141,6 +144,13 @@ public void deleteWorkspace(final WorkspaceIdRequestBody workspaceIdRequestBody) | |||
| configRepository.writeStandardWorkspace(persistedWorkspace); | |||
| } | |||
|
|
|||
| public WorkspaceReadList listWorkspaces() throws JsonValidationException, IOException { | |||
There was a problem hiding this comment.
Could you add unit test to verify this? You can add in WorkspacesHandlerTest.java
There was a problem hiding this comment.
Sure! I just added it @sherifnada ;-)
sherifnada
approved these changes
Jul 5, 2021
|
Thanks @mmolimar ! 馃帀 |
sherifnada
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds a new endpoint in the API to list all workspaces. Related with #4003
How
Update the YAML file containing the endpoints with the specification and the WorkspaceHandler to enable listing the workspaces.
Recommended reading order
config.ymlConfigurationApi.javaWorkspacesHandler.javaPre-merge Checklist
Expand the checklist which is relevant for this PR.
Connector checklist
airbyte_secretin the connector's spec./gradlew :airbyte-integrations:connectors:<name>:integrationTest./test connector=connectors/<name>command as documented here is passing.README.mddocs/SUMMARY.mdif it's a new connectordocs/integrations/<source or destination>/<name>.docs/integrations/.... See changelog exampledocs/integrations/README.mdcontains a reference to the new connector/publishcommand described hereConnector Generator checklist
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes