-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LOG_LEVEL for temporal #4532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@panhavad did you test this locally? I'm not sure this works as this is running on the temporal image and we do not control the logging |
@davinchia Yes, I did. It works fine. If using LOG_LEVEL=ERROR
If using LOG_LEVEL=INFO
If using LOG_LEVEL=DEBUG
|
Nice! |
davinchia
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Just add
LOG_LEVEL=${LOG_LEVEL}
for airbyte-temporal.How
This will allow the control on the log of airbyte-temporal too.
Tested with: "FATAL", "ERROR", "WARN", "INFO", "DEBUG", "TRACE"
None of them cause to crash the application.
Recommended reading order