Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摎 add doc to describe how CDK handles schemas #4537

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

sherifnada
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the CDK Connector Development Kit label Jul 4, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 4, 2021
@@ -0,0 +1,23 @@
# Defining your stream schemas
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avaidyanatha do you remember why we decided to duplicate these directories instead of linking to the docs outside of the docs/ directory?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow. What directories are we duplicating?

Copy link
Contributor Author

@sherifnada sherifnada Jul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

airbyte-cdk/python/docs/concepts/ and docs/contributing-to-airbyte/python/concepts/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaahhhh I remember now. Gitbook automatically replicated those files into /docs. I initially wanted to keep them in the code directory but that made Gitbook mad. So now we just do everything in the /docs directory.

Copy link
Contributor

@avaidyanatha avaidyanatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -0,0 +1,23 @@
# Defining your stream schemas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow. What directories are we duplicating?

@sherifnada sherifnada merged commit 21116ca into master Jul 6, 2021
@sherifnada sherifnada deleted the sherifnada-patch-1 branch July 6, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants