Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Kubernetes: Fix server starting up before Temporal ready to operate #4567

Merged
merged 2 commits into from
Jul 7, 2021
Merged

馃悰 Kubernetes: Fix server starting up before Temporal ready to operate #4567

merged 2 commits into from
Jul 7, 2021

Conversation

Phlair
Copy link
Contributor

@Phlair Phlair commented Jul 6, 2021 •
edited

What

Closes #4388

How

  • Refactor waitForTemporalServerAndLog out of TemporalPool into TemporalUtils. Whenever createTemporalService is called, we run through waitForTemporalServerAndLog before returning the temporalService, ensuring it is available.
  • Removed usage of docker-compose-wait as this makes it redundant.

Worth noting

  • This PR removes tests (TemporalPoolTest.java) for TemporalPool as it only had 1, which tested waitForTemporalServerAndLog. I've refactored that test into TemporalUtilsTest.java.

@Phlair Phlair requested a review from jrhizor July 6, 2021 13:28
@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Jul 6, 2021
@Phlair Phlair self-assigned this Jul 6, 2021
jrhizor
jrhizor approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@jrhizor jrhizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@Phlair Phlair merged commit 2ca4f94 into master Jul 7, 2021
@Phlair Phlair deleted the george/kube-wait-bug branch July 7, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

Assignees

@Phlair Phlair

Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubernetes looks like it's not working if server is available before scheduling functionality
2 participants
@Phlair @jrhizor