Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source GitHub: few updates #4598

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Source GitHub: few updates #4598

merged 2 commits into from
Jul 7, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Jul 7, 2021 •
edited

Add AIRBYTE_ENTRYPOINT to Dockerfile.
Add Changelog section to docs/integrations/sources/github.md.
Remove source-github/CHANGELOG.md file.

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@Zirochkaa
Few updates for GitHub connector
f702972 
Add `AIRBYTE_ENTRYPOINT` to `Dockerfile`.
Add `Changelog` section to `docs/integrations/sources/github.md`.
Remove `source-github/CHANGELOG.md` file.
@Zirochkaa Zirochkaa self-assigned this Jul 7, 2021
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 7, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Jul 7, 2021 •
edited by github-actions bot

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1007328670
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1007328670

@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Jul 7, 2021 •
edited by github-actions bot

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1007364883
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1007364883

@Zirochkaa Zirochkaa requested a review from sherifnada July 7, 2021 08:49
@Zirochkaa Zirochkaa changed the title Few updates for GitHub connector 🎉 Source GitHub: few updates Jul 7, 2021
@Zirochkaa Zirochkaa changed the title 🎉 Source GitHub: few updates Source GitHub: few updates Jul 7, 2021
@Zirochkaa Zirochkaa merged commit 3e37e90 into master Jul 7, 2021
@Zirochkaa Zirochkaa deleted the oleh/bump-github-version-update-changelog branch July 7, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevhenii-ldv yevhenii-ldv yevhenii-ldv approved these changes

@sherifnada sherifnada Awaiting requested review from sherifnada

Assignees

@Zirochkaa Zirochkaa

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/github connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zirochkaa @yevhenii-ldv @igrankova