Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Pipedrive: update money type to support floating point #4912

Merged
merged 5 commits into from
Jul 23, 2021

Conversation

gaart
Copy link
Contributor

@gaart gaart commented Jul 22, 2021

What

Change the json schema for the money to accept floating number as a value.
Fix for #4828

How

The integer type changed to the number for the value and weighted_value fields

Recommended reading order

  1. x.json

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Jul 22, 2021
@gaart gaart linked an issue Jul 22, 2021 that may be closed by this pull request
@gaart gaart requested a review from keu July 23, 2021 05:16
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to follow the checklist to bump the version and publish the connector!

@gaart
Copy link
Contributor Author

gaart commented Jul 23, 2021

/publish connector=connectors/source-pipedrive

🕑 connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/1059835420
✅ connectors/source-pipedrive https://github.com/airbytehq/airbyte/actions/runs/1059835420

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 23, 2021
@gaart gaart merged commit 743a054 into master Jul 23, 2021
@gaart gaart deleted the gaart/4828-pipedrive-source-normalization-error branch July 23, 2021 14:28
@gaart gaart restored the gaart/4828-pipedrive-source-normalization-error branch July 23, 2021 14:28
@swyxio swyxio deleted the gaart/4828-pipedrive-source-normalization-error branch October 12, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipedrive Source Normalization Error
2 participants