Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jamakase/use workspace #4918

Merged
merged 11 commits into from Jul 28, 2021
Merged

Jamakase/use workspace #4918

merged 11 commits into from Jul 28, 2021

Conversation

jamakase
Copy link
Contributor

@jamakase jamakase commented Jul 22, 2021 •
edited

What

Takes the first workspace from list for analytics ( Closes #4799 )

EDIT: as this part includes some refactoring for analytics - added work required for this task ( Closes #4958 )

How

  • Use useWorkspace hook instead of addressing config directly.
  • Add proper DI for AnalyticsService

Recommended reading order

  1. views/common/AnalyticsInitializer
  2. hooks/useWorkspace

@jamakase jamakase requested a review from cgardens July 23, 2021 16:35
@jamakase jamakase self-assigned this Jul 23, 2021
@jamakase jamakase marked this pull request as ready for review July 23, 2021 16:37
cgardens
cgardens approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@jamakase jamakase merged commit c3e6b3b into master Jul 28, 2021
@jamakase jamakase deleted the jamakase/use-workspace-id branch July 28, 2021 19:23
@cgardens cgardens mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgardens cgardens cgardens approved these changes

Assignees

@jamakase jamakase

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust OpenReplay snippet on all pages in web app Remove Frontend dependency on Default Workspace
2 participants
@jamakase @cgardens