Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/Bump Version Source File #5006

Merged
merged 6 commits into from Jul 27, 2021
Merged

Test/Bump Version Source File #5006

merged 6 commits into from Jul 27, 2021

Conversation

marcosmarxm
Copy link
Member

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 27, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 27, 2021

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1069346143
❌ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1069346143

Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I understand the purpose of this PR. It feels that the type change on port is not that useful, since this parameter will be converted to integer anyway?

@keu
Copy link
Contributor

keu commented Jul 27, 2021

@marcosmarxm I agree with @tuliren, it seems changing field type to "integer" in schema should be enough? Port can't be float/number.
Oops, I see you've already tried this.

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 27, 2021

@marcosmarxm I agree with @tuliren, it seem changing field type to "integer" in schema should be enough? Port can't be float/number.

I don't think I understand the purpose of this PR. It feels that the type change on port is not that useful, since this parameter will be converted to integer anyway?

The problem is that using integer type in the spec.json is not working. Take a look: #4952

Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that using integer type in the spec.json is not working.

Got it. This seems a regression on the frontend. There are several integer type parameters in the destination s3 spec. The last time I checked, they worked in production.

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 27, 2021

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1072774855
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1072774855

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Jul 27, 2021

/publish connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1072798873
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/1072798873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/file connectors/sources-files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants