馃悰 Bug Fix: Handle missing data types in migrations. #5089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when Airbyte exported configurations, even if there were not configurations of a type (e.g. operations) it would create a placeholder file for it in the export archive. The implementation has changed such that we cannot make that guarantee anymore. Specifically the postgres database only exports data that it actually has. The migration assumed that every archive it processed would contain data from all types. This commit makes the change to make sure that the types represented in the archive just need to be a subset of the types declared in the schema. In the future we can decide if we have an opinion on whether we should always export placeholder files. Since we have versions of Airbyte that don't do it though, we need to make this change in the migration code.
cgardens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5082
Previously, when Airbyte exported configurations, even if there were not configurations of a type (e.g. operations) it would create a placeholder file for it in the export archive. The implementation has changed such that we cannot make that guarantee anymore. Specifically the postgres database only exports data that it actually has.
The migration assumed that every archive it processed would contain data from all types. This commit makes the change to make sure that the types represented in the archive just need to be a subset of the types declared in the schema.
In the future we can decide if we have an opinion on whether we should always export placeholder files. Since we have versions of Airbyte that don't do it though, we need to make this change in the migration code.