Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New Source: LinkedIn Ads #5285

Merged
merged 68 commits into from Sep 24, 2021
Merged

🎉 New Source: LinkedIn Ads #5285

merged 68 commits into from Sep 24, 2021

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Aug 9, 2021 •
edited

What

#2589 - New Source: Linkedin Ads

How

Using Airbyte Python CDK - implemented native source connector for LinkedIn Ads/Marketing API

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@bazarnov bazarnov self-assigned this Aug 9, 2021
@bazarnov bazarnov linked an issue Aug 9, 2021 that may be closed by this pull request
New Source: Linkedin Ads #2589
Closed
@github-actions github-actions bot added the area/connectors Connector related issues label Aug 9, 2021
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
4fe8d03 
…e-linkedin-ads
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
b2d6f4d 
…e-linkedin-ads
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
717f96e 
…e-linkedin-ads
@bazarnov
edited dockerfile to use the alpine-base image, formated source.py
06a8b17
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
ec0581a 
…e-linkedin-ads
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
cc1700f 
…e-linkedin-ads
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
a8e2b6a 
…e-linkedin-ads
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
cf809c1 
…e-linkedin-ads
@bazarnov
minor edits
84dbce7
@bazarnov
added Accounts, CampaignGroups streams
40e8ba7
@bazarnov
added AccountUsers stream
91841fe
@bazarnov
Added incremental refresh to some streams
bc930fa
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
d90d8b7 
…e-linkedin-ads
@bazarnov
added acceptance-test, formated code
3d9848d
@bazarnov
corrections
4c20c49
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
74f42ca 
…e-linkedin-ads
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
89bf00b 
…e-linkedin-ads
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
3873b5f 
…e-linkedin-ads
@bazarnov
added Creatives stream, changed the StreamMixin to accept the parrent…
30e971f 
… stream class
@bazarnov
corrected campaigns schema
efc320b
@bazarnov
added AdSponsoredContents stream
72a861f
@bazarnov
added Analytics streams
d6fd81f
@bazarnov
edited Dockerfile, formated code
12243b1
@bazarnov
schema changes
9138d6c
@bazarnov
Merge remote-tracking branch 'origin/master' into bazarnov/2589-sourc…
bcdf609 
…e-linkedin-ads
@bazarnov
formated
5a7e990
@jrhizor jrhizor temporarily deployed to more-secrets September 18, 2021 10:03 Inactive
Phlair
Phlair approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@Phlair Phlair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really like the thorough unit tests in here @bazarnov!

It would be really useful for future developers if you could add a bootstrap.md explaining the API.

@bazarnov
Copy link
Collaborator Author

bazarnov commented Sep 21, 2021 •
edited by github-actions bot

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1257699321
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1257699321
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        45     45     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  776    430    45%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                               Stmts   Miss  Cover
	 ------------------------------------------------------
	 source_linkedin_ads/__init__.py        2      0   100%
	 source_linkedin_ads/analytics.py      45      1    98%
	 source_linkedin_ads/source.py        153     66    57%
	 source_linkedin_ads/utils.py          87     10    89%
	 ------------------------------------------------------
	 TOTAL                                287     77    73%

@bazarnov bazarnov temporarily deployed to more-secrets September 21, 2021 13:05 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 21, 2021 13:06 Inactive
antixar
antixar approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 18:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 18:53 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 19:00 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets September 23, 2021 19:09 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 19:10 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 23, 2021 19:25 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Sep 24, 2021 •
edited by github-actions bot

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1271217997
❌ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1271217997
🐛 https://gradle.com/s/xltrn65cbwrp4

@bazarnov bazarnov temporarily deployed to more-secrets September 24, 2021 20:12 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 24, 2021 20:13 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Sep 24, 2021 •
edited by github-actions bot

/test connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1271304111
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1271304111
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        45     45     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              158    109    31%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     25    39%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py      75     11    85%
	 ------------------------------------------------------------------------
	 TOTAL                                                  776    430    45%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                               Stmts   Miss  Cover
	 ------------------------------------------------------
	 source_linkedin_ads/__init__.py        2      0   100%
	 source_linkedin_ads/analytics.py      45      1    98%
	 source_linkedin_ads/source.py        153     66    57%
	 source_linkedin_ads/utils.py          87     10    89%
	 ------------------------------------------------------
	 TOTAL                                287     77    73%

@bazarnov bazarnov temporarily deployed to more-secrets September 24, 2021 20:44 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets September 24, 2021 20:45 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Sep 24, 2021 •
edited by github-actions bot

/publish connector=connectors/source-linkedin-ads

🕑 connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1271386941
✅ connectors/source-linkedin-ads https://github.com/airbytehq/airbyte/actions/runs/1271386941

@jrhizor jrhizor temporarily deployed to more-secrets September 24, 2021 21:15 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets September 24, 2021 22:58 Inactive
@bazarnov bazarnov merged commit 2f835e4 into master Sep 24, 2021
@bazarnov bazarnov deleted the bazarnov/2589-source-linkedin-ads branch September 24, 2021 22:58
@jrhizor jrhizor mentioned this pull request Sep 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi left review comments

@midavadim midavadim midavadim approved these changes

@antixar antixar antixar approved these changes

@Phlair Phlair Phlair approved these changes

Assignees

@bazarnov bazarnov

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Source: Linkedin Ads
6 participants
@bazarnov @Phlair @midavadim @antixar @lazebnyi @jrhizor