Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix postgres integration tests #5370

Merged
merged 2 commits into from Aug 12, 2021
Merged

fix postgres integration tests #5370

merged 2 commits into from Aug 12, 2021

Conversation

subodh1810
Copy link
Contributor

@subodh1810 subodh1810 commented Aug 12, 2021

Issue : #5371
There are multiple issues with the postgres connector

  1. After we introduced validation for config objects in the PR 🎉 All java connectors: Added configValidator to check, discover, read and write calls #4699 , the postgres source publish and integration tests have been broken. Which also means the validation changes have not been published for postgres source yet
  2. The CdcPostgresSourceAcceptanceTest was never running in CDC mode, it was running in Standard mode which means it was not really testing what it was supposed to test
  3. The CdcPostgresSourceComprehensiveTest was never running in CDC mode, it was running in Standard mode which means it was not really testing what it was supposed to test. Once I enabled the CDC I realised that there were data types that started breaking, for now I have just ignored the data types, follow up issue to fix it Fix data type tests in CdcPostgresSourceDatatypeTest #5382

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@subodh1810 subodh1810 self-assigned this Aug 12, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Aug 12, 2021
@subodh1810
Copy link
Contributor Author

subodh1810 commented Aug 12, 2021

/test connector=source-postgres

🕑 source-postgres https://github.com/airbytehq/airbyte/actions/runs/1124281184
✅ source-postgres https://github.com/airbytehq/airbyte/actions/runs/1124281184

@jrhizor jrhizor temporarily deployed to more-secrets August 12, 2021 14:36 Inactive
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have the issue can you send me the link to prioritize?

@subodh1810
Copy link
Contributor Author

subodh1810 commented Aug 12, 2021

/test connector=source-postgres

🕑 source-postgres https://github.com/airbytehq/airbyte/actions/runs/1125300175
✅ source-postgres https://github.com/airbytehq/airbyte/actions/runs/1125300175

@jrhizor jrhizor temporarily deployed to more-secrets August 12, 2021 20:17 Inactive
@subodh1810
Copy link
Contributor Author

@sherifnada follow up issue : #5382

@subodh1810 subodh1810 merged commit e222835 into master Aug 12, 2021
@subodh1810 subodh1810 deleted the fix-postgres-publish branch August 12, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants